lkml.org 
[lkml]   [2017]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function
    Date
    Currently davinci_gpio_irq_setup return value is ignored. Handle the
    return value appropriately.

    Signed-off-by: Keerthy <j-keerthy@ti.com>
    ---
    drivers/gpio/gpio-davinci.c | 18 +++++++++++++-----
    1 file changed, 13 insertions(+), 5 deletions(-)

    diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
    index 2c88054..932f270 100644
    --- a/drivers/gpio/gpio-davinci.c
    +++ b/drivers/gpio/gpio-davinci.c
    @@ -233,15 +233,23 @@ static int davinci_gpio_probe(struct platform_device *pdev)
    chips->regs[bank] = gpio_base + offset_array[bank];

    ret = devm_gpiochip_add_data(dev, &chips->chip, chips);
    + if (ret)
    + goto err;
    +
    + platform_set_drvdata(pdev, chips);
    + ret = davinci_gpio_irq_setup(pdev);
    if (ret) {
    - ctrl_num = 0;
    - bank_base = 0;
    - return ret;
    + platform_set_drvdata(pdev, NULL);
    + goto err;
    }

    - platform_set_drvdata(pdev, chips);
    - davinci_gpio_irq_setup(pdev);
    return 0;
    +
    +err:
    + ctrl_num = 0;
    + bank_base = 0;
    +
    + return ret;
    }

    /*--------------------------------------------------------------------------*/
    --
    1.9.1
    \
     
     \ /
      Last update: 2017-07-18 13:07    [W:4.901 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site