Messages in this thread | | | Date | Mon, 17 Jul 2017 22:49:35 +0200 | From | Boris Brezillon <> | Subject | Re: [PATCH] mtd: spear_smi: add NULL check on devm_kzalloc() return value |
| |
Le Thu, 6 Jul 2017 17:25:50 -0500, "Gustavo A. R. Silva" <garsilva@embeddedor.com> a écrit :
> Check return value from call to devm_kzalloc() > in order to prevent a NULL pointer dereference. > > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression x; > identifier fld; > @@ > > * x = devm_kzalloc(...); > ... when != x == NULL > x->fld > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> --- > drivers/mtd/devices/spear_smi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c > index dd50698..ddf4789 100644 > --- a/drivers/mtd/devices/spear_smi.c > +++ b/drivers/mtd/devices/spear_smi.c > @@ -775,6 +775,8 @@ static int spear_smi_probe_config_dt(struct platform_device *pdev, > pdata->board_flash_info = devm_kzalloc(&pdev->dev, > sizeof(*pdata->board_flash_info), > GFP_KERNEL); > + if (!pdata->board_flash_info) > + return -ENOMEM; > > /* Fill structs for each subnode (flash device) */ > while ((pp = of_get_next_child(np, pp))) {
| |