lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 29/95] Input: yealink - validate number of endpoints before using them
    3.2.91-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 5cc4a1a9f5c179795c8a1f2b0f4361829d6a070e upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should a malicious device lack endpoints.

    Fixes: aca951a22a1d ("[PATCH] input-driver-yealink-P1K-usb-phone")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/input/misc/yealink.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/input/misc/yealink.c
    +++ b/drivers/input/misc/yealink.c
    @@ -867,6 +867,10 @@ static int usb_probe(struct usb_interfac
    int ret, pipe, i;

    interface = intf->cur_altsetting;
    +
    + if (interface->desc.bNumEndpoints < 1)
    + return -ENODEV;
    +
    endpoint = &interface->endpoint[0].desc;
    if (!usb_endpoint_is_int_in(endpoint))
    return -ENODEV;
    \
     
     \ /
      Last update: 2017-07-16 16:50    [W:4.098 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site