lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 28/95] Input: cm109 - validate number of endpoints before using them
    3.2.91-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit ac2ee9ba953afe88f7a673e1c0c839227b1d7891 upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should a malicious device lack endpoints.

    Fixes: c04148f915e5 ("Input: add driver for USB VoIP phones with CM109...")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/input/misc/cm109.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/input/misc/cm109.c
    +++ b/drivers/input/misc/cm109.c
    @@ -663,6 +663,10 @@ static int cm109_usb_probe(struct usb_in
    int error = -ENOMEM;

    interface = intf->cur_altsetting;
    +
    + if (interface->desc.bNumEndpoints < 1)
    + return -ENODEV;
    +
    endpoint = &interface->endpoint[0].desc;

    if (!usb_endpoint_is_int_in(endpoint))
    \
     
     \ /
      Last update: 2017-07-16 16:48    [W:4.101 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site