lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 15/95] USB: idmouse: fix NULL-deref at probe
    3.2.91-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit b0addd3fa6bcd119be9428996d5d4522479ab240 upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should a malicious device lack endpoints.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/misc/idmouse.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/usb/misc/idmouse.c
    +++ b/drivers/usb/misc/idmouse.c
    @@ -346,6 +346,9 @@ static int idmouse_probe(struct usb_inte
    if (iface_desc->desc.bInterfaceClass != 0x0A)
    return -ENODEV;

    + if (iface_desc->desc.bNumEndpoints < 1)
    + return -ENODEV;
    +
    /* allocate memory for our device state and initialize it */
    dev = kzalloc(sizeof(*dev), GFP_KERNEL);
    if (dev == NULL)
    \
     
     \ /
      Last update: 2017-07-16 16:10    [W:4.095 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site