lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 019/178] target: Fix VERIFY_16 handling in sbc_parse_cdb
    3.16.46-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Max Lohrmann <post@wickenrode.com>

    commit 13603685c1f12c67a7a2427f00b63f39a2b6f7c9 upstream.

    As reported by Max, the Windows 2008 R2 chkdsk utility expects
    VERIFY_16 to be supported, and does not handle the returned
    CHECK_CONDITION properly, resulting in an infinite loop.

    The kernel will log huge amounts of this error:

    kernel: TARGET_CORE[iSCSI]: Unsupported SCSI Opcode 0x8f, sending
    CHECK_CONDITION.

    Signed-off-by: Max Lohrmann <post@wickenrode.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/target/target_core_sbc.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    --- a/drivers/target/target_core_sbc.c
    +++ b/drivers/target/target_core_sbc.c
    @@ -950,9 +950,15 @@ sbc_parse_cdb(struct se_cmd *cmd, struct
    return ret;
    break;
    case VERIFY:
    + case VERIFY_16:
    size = 0;
    - sectors = transport_get_sectors_10(cdb);
    - cmd->t_task_lba = transport_lba_32(cdb);
    + if (cdb[0] == VERIFY) {
    + sectors = transport_get_sectors_10(cdb);
    + cmd->t_task_lba = transport_lba_32(cdb);
    + } else {
    + sectors = transport_get_sectors_16(cdb);
    + cmd->t_task_lba = transport_lba_64(cdb);
    + }
    cmd->execute_cmd = sbc_emulate_noop;
    goto check_lba;
    case REZERO_UNIT:
    \
     
     \ /
      Last update: 2017-07-16 15:59    [W:4.173 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site