Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 04/11] fbdev: da8xx-fb: Drop unnecessary static | Date | Sat, 15 Jul 2017 22:07:39 +0200 |
| |
Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit.
The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+>
@@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- These patches are all independent of each other.
drivers/video/fbdev/da8xx-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c --- a/drivers/video/fbdev/da8xx-fb.c +++ b/drivers/video/fbdev/da8xx-fb.c @@ -1341,7 +1341,7 @@ static int fb_probe(struct platform_devi { struct da8xx_lcdc_platform_data *fb_pdata = dev_get_platdata(&device->dev); - static struct resource *lcdc_regs; + struct resource *lcdc_regs; struct lcd_ctrl_config *lcd_cfg; struct fb_videomode *lcdc_info; struct fb_info *da8xx_fb_info;
| |