lkml.org 
[lkml]   [2017]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH for v4.9 LTS 70/87] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int
    Date
    From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>

    [ Upstream commit b007f09072ca8afa118ade333e717ba443e8d807 ]

    > cat /proc/sys/net/ipv4/tcp_notsent_lowat
    -1
    > echo 4294967295 > /proc/sys/net/ipv4/tcp_notsent_lowat
    -bash: echo: write error: Invalid argument
    > echo -2147483648 > /proc/sys/net/ipv4/tcp_notsent_lowat
    > cat /proc/sys/net/ipv4/tcp_notsent_lowat
    -2147483648

    but in documentation we have "tcp_notsent_lowat - UNSIGNED INTEGER"

    v2: simplify to just proc_douintvec
    Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    net/ipv4/sysctl_net_ipv4.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
    index 80bc36b25de2..566cfc50f7cf 100644
    --- a/net/ipv4/sysctl_net_ipv4.c
    +++ b/net/ipv4/sysctl_net_ipv4.c
    @@ -958,7 +958,7 @@ static struct ctl_table ipv4_net_table[] = {
    .data = &init_net.ipv4.sysctl_tcp_notsent_lowat,
    .maxlen = sizeof(unsigned int),
    .mode = 0644,
    - .proc_handler = proc_dointvec,
    + .proc_handler = proc_douintvec,
    },
    #ifdef CONFIG_IP_ROUTE_MULTIPATH
    {
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-07-15 03:28    [W:4.164 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site