lkml.org 
[lkml]   [2017]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC PATCH v1 00/11] Create fast idle path for short idle periods
On Tue, Jul 11, 2017 at 06:09:27PM +0200, Frederic Weisbecker wrote:

> So I'd rather put that on can_stop_idle_tick().

That function needs a fix.. That's not in fact an identity (although it
turns out it is for the 4 default HZ values).

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index c7a899c5ce64..91433bc4a723 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -882,7 +882,7 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
}

if (unlikely(ts->nohz_mode == NOHZ_MODE_INACTIVE)) {
- ts->sleep_length = NSEC_PER_SEC / HZ;
+ ts->sleep_length = TICK_NSEC;
return false;
}

\
 
 \ /
  Last update: 2017-07-12 20:11    [W:0.775 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site