lkml.org 
[lkml]   [2017]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] pinctrl: stm32: select IRQ_DOMAIN_HIERARCHY instead of depends on
    Date
    Drivers that need IRQ_DOMAIN_HIERARCHY should "select" it, but
    drivers/pinctrl/stm32/Kconfig is the only exception that uses
    "depends on" syntax. This prevents GPIO drivers from select'ing
    IRQ_DOMAIN_HIERARCHY.

    For example, if I add "select IRQ_DOMAIN_HIERARCHY" to GPIO_XGENE_SB,
    I get the following recursive dependency error.

    drivers/gpio/Kconfig:13:error: recursive dependency detected!
    For a resolution refer to Documentation/kbuild/kconfig-language.txt
    subsection "Kconfig recursive dependency limitations"
    drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_STM32
    For a resolution refer to Documentation/kbuild/kconfig-language.txt
    subsection "Kconfig recursive dependency limitations"
    drivers/pinctrl/stm32/Kconfig:3: symbol PINCTRL_STM32 is selected by PINCTRL_STM32F429
    For a resolution refer to Documentation/kbuild/kconfig-language.txt
    subsection "Kconfig recursive dependency limitations"
    drivers/pinctrl/stm32/Kconfig:11: symbol PINCTRL_STM32F429 depends on IRQ_DOMAIN_HIERARCHY
    For a resolution refer to Documentation/kbuild/kconfig-language.txt
    subsection "Kconfig recursive dependency limitations"
    kernel/irq/Kconfig:67: symbol IRQ_DOMAIN_HIERARCHY is selected by GPIO_XGENE_SB
    For a resolution refer to Documentation/kbuild/kconfig-language.txt
    subsection "Kconfig recursive dependency limitations"
    drivers/gpio/Kconfig:502: symbol GPIO_XGENE_SB depends on GPIOLIB

    Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    ---

    drivers/pinctrl/stm32/Kconfig | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
    index 3b8026fca057..7e1fe39a56a5 100644
    --- a/drivers/pinctrl/stm32/Kconfig
    +++ b/drivers/pinctrl/stm32/Kconfig
    @@ -6,29 +6,30 @@ config PINCTRL_STM32
    select PINMUX
    select GENERIC_PINCONF
    select GPIOLIB
    + select IRQ_DOMAIN_HIERARCHY
    select MFD_SYSCON

    config PINCTRL_STM32F429
    bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429
    - depends on OF && IRQ_DOMAIN_HIERARCHY
    + depends on OF
    default MACH_STM32F429
    select PINCTRL_STM32

    config PINCTRL_STM32F469
    bool "STMicroelectronics STM32F469 pin control" if COMPILE_TEST && !MACH_STM32F469
    - depends on OF && IRQ_DOMAIN_HIERARCHY
    + depends on OF
    default MACH_STM32F469
    select PINCTRL_STM32

    config PINCTRL_STM32F746
    bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746
    - depends on OF && IRQ_DOMAIN_HIERARCHY
    + depends on OF
    default MACH_STM32F746
    select PINCTRL_STM32

    config PINCTRL_STM32H743
    bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743
    - depends on OF && IRQ_DOMAIN_HIERARCHY
    + depends on OF
    default MACH_STM32H743
    select PINCTRL_STM32
    endif
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-07-12 01:13    [W:2.183 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site