Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length | Date | Tue, 11 Jul 2017 16:17:05 +0000 |
| |
On Tue, 2017-07-11 at 00:22 -0700, Nicholas A. Bellinger wrote: > So rejecting this case as already done in commit abb85a9b51 is the > correct approach for >= v4.3.y.
Hello Nic,
I hope that you agree that the current target_cmd_size_check() implementation is complicated and ugly. Patch 30/33 of the patch series I referred to in my e-mail removes a significant number of lines of code from that function. So my patch series not only makes target_cmd_size_check() easier to maintain and to verify but it makes that function also faster. Hence please reconsider the approach from my patch series. For patch 30/33, see also https://www.spinics.net/lists/target-devel/msg15384.html.
Bart.
| |