lkml.org 
[lkml]   [2017]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/7] platform/x86: compal-laptop: constify attribute_group structures.
    Date
    attribute_groups are not supposed to change at runtime. All functions
    working with attribute_groups provided by <linux/sysfs.h> work
    with const attribute_group. So mark the non-const structs as const.

    File size before:
    text data bss dec hex filename
    6781 6144 34 12959 329f drivers/platform/x86/compal-laptop.o

    File size After adding 'const':
    text data bss dec hex filename
    6845 6080 34 12959 329f drivers/platform/x86/compal-laptop.o

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    drivers/platform/x86/compal-laptop.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c
    index e1c2b6d..a8e4a53 100644
    --- a/drivers/platform/x86/compal-laptop.c
    +++ b/drivers/platform/x86/compal-laptop.c
    @@ -718,7 +718,7 @@ static DEVICE_ATTR(pwm1_enable,
    &dev_attr_wake_up_mouse.attr,
    NULL
    };
    -static struct attribute_group compal_platform_attr_group = {
    +static const struct attribute_group compal_platform_attr_group = {
    .attrs = compal_platform_attrs
    };

    --
    1.9.1
    \
     
     \ /
      Last update: 2017-07-11 12:51    [W:3.022 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site