Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH] net: usb: qmi_wwan: constify attribute_group structures. | Date | Mon, 10 Jul 2017 13:19:07 +0530 |
| |
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/netdevice.h> work with const attribute_group. So mark the non-const structs as const.
File size before: text data bss dec hex filename 16831 464 0 17295 438f drivers/net/usb/qmi_wwan.o
File size After adding 'const': text data bss dec hex filename 16895 400 0 17295 438f drivers/net/usb/qmi_wwan.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/net/usb/qmi_wwan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 5894e3c..b2ddd5c 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -434,7 +434,7 @@ static ssize_t del_mux_store(struct device *d, struct device_attribute *attr, c NULL, }; -static struct attribute_group qmi_wwan_sysfs_attr_group = { +static const struct attribute_group qmi_wwan_sysfs_attr_group = { .name = "qmi", .attrs = qmi_wwan_sysfs_attrs, }; -- 1.9.1
| |