Messages in this thread | | | Date | Mon, 10 Jul 2017 14:28:43 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH] nvmem: include linux/err.h from header |
| |
On 10/07/2017 at 14:10:03 +0200, Arnd Bergmann wrote: > On Mon, Jul 10, 2017 at 1:33 PM, Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > > > > > > On 10/07/17 12:22, Arnd Bergmann wrote: > >> > >> The new support for nvmem devices from the rtc layer caused a build > >> error in some configurations: > >> > >> include/linux/nvmem-provider.h: In function 'nvmem_register': > >> include/linux/nvmem-provider.h:51:9: error: implicit declaration of > >> function 'ERR_PTR' [-Werror=implicit-function-declaration] > >> > >> This adds the missing include to ensure we can always include > >> the header. > >> > >> Fixes: 697e5a47aa12 ("rtc: add generic nvmem support") > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> --- > >> I'd suggest adding this patch in the rtc tree on top of the > >> nvmem support there. > > > > > > Thanks for the patch, we would need similar patch for > > include/linux/nvmem-consumer.h too. > > Makes sense, yes. Can you do that for 4.14? My patch for now is > needed to fix a build regression in the rtc-next tree that I > assume will otherwise make it into the 4.13 release. >
Yes, I'm planning to send my PR soon.
-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |