Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags | Date | Fri, 09 Jun 2017 17:04:24 +0100 |
| |
Jeff Layton <jlayton@redhat.com> wrote:
> I guess you mean stuff like affs_fill_super which does: > > sb->s_flags |= MS_NODEV | MS_NOSUID; > > It seems like it's doing that too late to be useful.
Actually, after the change, it seems nothing actually tests SB_NOSUID, SB_NODEV or SB_NOEXEC, so those bits should probably be removed.
I also wonder if the internal MS_ flags (eg. MS_SUBMOUNT) should be removed from the UAPI header.
David
| |