lkml.org 
[lkml]   [2017]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] loop: fix error handling regression
From
Date
On 06/09/2017 04:19 AM, Arnd Bergmann wrote:
> gcc points out an unusual indentation:
>
> drivers/block/loop.c: In function 'loop_set_status':
> drivers/block/loop.c:1149:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
> if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
> ^~
> drivers/block/loop.c:1152:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
> goto exit;
>
> This was introduced by a new feature that accidentally moved the opening
> braces from one condition to another. Adding a second pair of braces
> makes it work correctly again and also more readable.

Thanks for fixing this Arnd, I did notice (and complained to Hannes) this
yesterday. Added.

--
Jens Axboe

\
 
 \ /
  Last update: 2017-06-12 01:48    [W:0.050 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site