Messages in this thread | | | Date | Fri, 9 Jun 2017 15:16:10 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 1/7] net: dsa: mv888e6xxx: do not use netdev printing |
| |
On Thu, Jun 08, 2017 at 06:34:08PM -0400, Vivien Didelot wrote: > The mv888e6xxx driver accesses a port's netdev mostly for printing. > > This is bad for 2 reasons: DSA and CPU ports do not have a netdev > pointer; it doesn't give us a correct picture of why a DSA driver might > need to access a port's netdev. > > Instead simply use dev_* printing functions with chip->dev (or ds->dev > depending on the scope, both guaranteed to exist), with a p%d prefix for > the target port. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |