Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 8 Jun 2017 17:19:15 +0200 | Subject | Re: [PATCH 2/3] media: ngene: Replace semaphore stream_mutex with mutex |
| |
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan <binoy.jayan@linaro.org> wrote: > The semaphore 'stream_mutex' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org> > ---
Looks correct, though I wonder whether it would be nicer to move the mutex_lock/unlock() to the caller to avoid repeating the unlock() five times.
Either way,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |