lkml.org 
[lkml]   [2017]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ARM: samsung: Save defconfig for Exynos, S3C and S5P configs
On Thu, Jun 8, 2017 at 8:45 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Wed, Jun 07, 2017 at 09:49:58PM +0200, Arnd Bergmann wrote:
>> On Wed, Jun 7, 2017 at 8:18 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> > Some configs for Samsung ARM SoCs were not updated for some time and
>> > they still contain obsolete Kconfig entries. Generate new defconfig for
>> > all Samsung ARM architectures (Exynos, S3C24xx, S3C64xx, S5Pv210).
>> >
>> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> Hi Krzysztof,
>>
>> Updating the defconfig files is good, but I'm always a little unsure
>> about loss of
>> information when we do that. Would it be possible for you to split this patch
>> into two halves, with one of them just reordering the entries that moved,
>> and the second one removing the entries that have disappeared, with an
>> explanation for why they are no longer there? That would let us see whether
>> the change was intentional and avoid problems from renamed Kconfig
>> symbols that are no longer enabled afterwards.
>
> Splitting the change into two commits (reorder and removal) makes sense.
> However getting the information why some things were removed, will
> require more effort. I'll see what I can do.

Ok, thanks!

Arnd

\
 
 \ /
  Last update: 2017-06-12 01:22    [W:0.041 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site