Messages in this thread | | | Subject | RE: Re: [PATCH] devfreq: exynos-ppmu: Staticize event list | From | MyungJoo Ham <> | Date | Fri, 09 Jun 2017 00:28:27 +0000 |
| |
> Hi Krzysztof, > > On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote: > > The ppmu_events array is accessed only in this compilation unit so it > > can be made static. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > drivers/devfreq/event/exynos-ppmu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > > index 9b7350935b73..c68f3b5a10b5 100644 > > --- a/drivers/devfreq/event/exynos-ppmu.c > > +++ b/drivers/devfreq/event/exynos-ppmu.c > > @@ -44,7 +44,7 @@ struct exynos_ppmu { > > { "ppmu-event2-"#name, PPMU_PMNCNT2 }, \ > > { "ppmu-event3-"#name, PPMU_PMNCNT3 } > > > > -struct __exynos_ppmu_events { > > +static struct __exynos_ppmu_events { > > char *name; > > int id; > > } ppmu_events[] = { > > > > Looks good to me. > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Cheers, MyungJoo
| |