Messages in this thread | | | Date | Thu, 08 Jun 2017 23:10:06 +0200 | From | Paul Cercueil <> | Subject | Re: [PATCH 04/15] clk: Add Ingenic jz4770 CGU driver |
| |
Hi,
>> + register_syscore_ops(&jz4770_cgu_pm_ops); >> +#endif >> +} >> +CLK_OF_DECLARE(jz4770_cgu, "ingenic,jz4770-cgu", jz4770_cgu_init); > > Any reason this can't be a platform driver? Please add a comment > above CLK_OF_DECLARE describing what is preventing that.
It would probably be possible, if we cared about having a platform driver. But we will only ever probe it from devicetree, just like with the already existing jz4740-cgu and jz4780-cgu drivers.
>> diff --git a/include/dt-bindings/clock/jz4770-cgu.h >> b/include/dt-bindings/clock/jz4770-cgu.h >> new file mode 100644 >> index 000000000000..54b8b2ae4a73 >> --- /dev/null >> +++ b/include/dt-bindings/clock/jz4770-cgu.h > > Can you split this file off into a different patch? That way clk > tree can apply clk patches on top of a stable branch where this > file lives by itself.
Sure.
Thanks, - Paul
| |