lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] Add bcm2835aux interrupt controller
Hi Phil,

> Phil Elwell <phil@raspberrypi.org> hat am 7. Juni 2017 um 13:11 geschrieben:
>
>
> Devices in the AUX block share a common interrupt line, with a register
> indicating which devices have active IRQs. Expose this as a nested
> interrupt controller to avoid IRQ sharing problems (easily observed if
> UART1 and SPI1/2 are enabled simultaneously).
>
> The interrupt functionality could arguably be forked off as a separate
> irqchip driver, but the clock driver has already claimed the AUX_IRQ
> register so some driver and DT surgery would still be required.
> Eric Anholt thought that including it here is reasonable, but I'm
> prepared to split it out if this is considered too hacky.

in order to give the maintainers (e.g. irqchip) a chance, they should be included into CC.

>
> Phil Elwell (2):
> clk: bcm2835: Add AUX interrupt controller

Either way the dt-binding must be updated as a separate patch. So Rob can review it.

Thanks for submitting this upstream.

Stefan

> ARM: dts: bcm283x: Enable AUX interrupt controller
>
> arch/arm/boot/dts/bcm283x.dtsi | 12 +++-
> drivers/clk/bcm/clk-bcm2835-aux.c | 120 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 129 insertions(+), 3 deletions(-)
>
> --
> 1.9.1
>

\
 
 \ /
  Last update: 2017-06-12 01:12    [W:1.085 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site