Messages in this thread | | | Subject | Re: [PATCH net-next 2/5] net: dsa: check VLAN capability of every switch | From | Florian Fainelli <> | Date | Wed, 7 Jun 2017 12:39:51 -0700 |
| |
On 06/06/2017 01:56 PM, Vivien Didelot wrote: > Now that the VLAN object is propagated to every switch chip of the > switch fabric, we can easily ensure that they all support the required > VLAN operations before modifying an entry on a single switch. > > To achieve that, remove the condition skipping other target switches, > and add a bitmap of VLAN members, eventually containing the target port, > if we are programming the switch target.
You could add in the commit message that with this commit, there is not actually a functional change yet because we have one (and only one) bit set in the members bitmap.
> > This will allow us to easily add other VLAN members, such as the DSA or > CPU ports (to introduce cross-chip VLAN support) or the other port > members if we want to reduce hardware accesses later. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |