lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 18/34] x86/efi: Update EFI pagetable creation to work with SME
    Date
    When SME is active, pagetable entries created for EFI need to have the
    encryption mask set as necessary.

    When the new pagetable pages are allocated they are mapped encrypted. So,
    update the efi_pgt value that will be used in cr3 to include the encryption
    mask so that the PGD table can be read successfully. The pagetable mapping
    as well as the kernel are also added to the pagetable mapping as encrypted.
    All other EFI mappings are mapped decrypted (tables, etc.).

    Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
    ---
    arch/x86/platform/efi/efi_64.c | 15 +++++++++++----
    1 file changed, 11 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
    index eb8dff1..ed37fa3 100644
    --- a/arch/x86/platform/efi/efi_64.c
    +++ b/arch/x86/platform/efi/efi_64.c
    @@ -327,7 +327,7 @@ void efi_sync_low_kernel_mappings(void)

    int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
    {
    - unsigned long pfn, text;
    + unsigned long pfn, text, pf;
    struct page *page;
    unsigned npages;
    pgd_t *pgd;
    @@ -335,7 +335,12 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
    if (efi_enabled(EFI_OLD_MEMMAP))
    return 0;

    - efi_scratch.efi_pgt = (pgd_t *)__pa(efi_pgd);
    + /*
    + * Since the PGD is encrypted, set the encryption mask so that when
    + * this value is loaded into cr3 the PGD will be decrypted during
    + * the pagetable walk.
    + */
    + efi_scratch.efi_pgt = (pgd_t *)__sme_pa(efi_pgd);
    pgd = efi_pgd;

    /*
    @@ -345,7 +350,8 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
    * phys_efi_set_virtual_address_map().
    */
    pfn = pa_memmap >> PAGE_SHIFT;
    - if (kernel_map_pages_in_pgd(pgd, pfn, pa_memmap, num_pages, _PAGE_NX | _PAGE_RW)) {
    + pf = _PAGE_NX | _PAGE_RW | _PAGE_ENC;
    + if (kernel_map_pages_in_pgd(pgd, pfn, pa_memmap, num_pages, pf)) {
    pr_err("Error ident-mapping new memmap (0x%lx)!\n", pa_memmap);
    return 1;
    }
    @@ -388,7 +394,8 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
    text = __pa(_text);
    pfn = text >> PAGE_SHIFT;

    - if (kernel_map_pages_in_pgd(pgd, pfn, text, npages, _PAGE_RW)) {
    + pf = _PAGE_RW | _PAGE_ENC;
    + if (kernel_map_pages_in_pgd(pgd, pfn, text, npages, pf)) {
    pr_err("Failed to map kernel text 1:1\n");
    return 1;
    }
    \
     
     \ /
      Last update: 2017-06-12 01:11    [W:4.091 / U:1.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site