| Date | Wed, 7 Jun 2017 16:09:35 +0200 | From | Boris Brezillon <> | Subject | Re: [PATCH v5 19/23] mtd: nand: denali: fix raw and oob accessors for syndrome page layout |
| |
On Wed, 7 Jun 2017 20:52:28 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> > +static void denali_read_buf(struct mtd_info *mtd, uint8_t *buf, int len) > +{ > + struct denali_nand_info *denali = mtd_to_denali(mtd); > + int i; > + > + iowrite32(MODE_11 | BANK(denali->flash_bank) | 2, denali->flash_mem);
What is this '| 2'? You seem to use it a lot. Can you define a macro and maybe add a comment if the macro name is not self-descriptive.
|