Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 7 Jun 2017 16:40:13 +0300 | Subject | Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver |
| |
On Wed, Jun 7, 2017 at 3:15 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > On Tue, Jun 06, 2017 at 05:23:56PM +0300, Andy Shevchenko wrote: >> Follow the pattern, please, I suppose >> ti_pmic_tps68470.c > > This pattern is weird. "ti" in front of the file name is redundant, and in > very few places the vendor prefix is used anyway. Especially when the chip > has a proper name --- as this one does. > > I assume for the Intel PMICs it could be there for a couple of reasons which > are > > 1) lack of a clearly unique chip ID and > > 2) the use of common frameworklet for Intel PMICs. > > There are also no other PMIC chips supported currently. > > The pmic_tps68470 naming is in line with the GPIO driver (apart from the > dash / underscore difference).
Since
% git ls-files *pmic*
returns somewhat interesting results, I would even go further and use
tps68470.c here
and
s/ti_pmic/tps6840/g
inside the file.
Would it work for you?
-- With Best Regards, Andy Shevchenko
| |