Messages in this thread | | | Date | Wed, 7 Jun 2017 15:15:04 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver |
| |
On Tue, Jun 06, 2017 at 05:23:56PM +0300, Andy Shevchenko wrote: > Follow the pattern, please, I suppose > ti_pmic_tps68470.c
This pattern is weird. "ti" in front of the file name is redundant, and in very few places the vendor prefix is used anyway. Especially when the chip has a proper name --- as this one does.
I assume for the Intel PMICs it could be there for a couple of reasons which are
1) lack of a clearly unique chip ID and
2) the use of common frameworklet for Intel PMICs.
There are also no other PMIC chips supported currently.
The pmic_tps68470 naming is in line with the GPIO driver (apart from the dash / underscore difference).
-- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
| |