Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 7 Jun 2017 13:46:37 +0300 | Subject | Re: [PATCH] acpi: handle the acpi hotplug schedule error |
| |
On Wed, Jun 7, 2017 at 1:18 PM, joeyli <jlee@suse.com> wrote: > On Wed, Jun 07, 2017 at 11:36:55AM +0300, Andy Shevchenko wrote: >> On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote: >> > Kernel should decrements the reference count of acpi device >> > when scheduling acpi hotplug work is failed, and also evaluates >> > _OST to notify BIOS the failure.
> So, do you mean like this?
Yes, see below.
> > - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > - return; > + if (hotplug_event) {
> + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > + return;
> + else
It's redundant...
> + goto err_put_device;
...perhaps
if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type))) goto err_put_device; return;
> + }
> > acpi_bus_put_acpi_device(adev); > return; > > +err_put_device: > + acpi_bus_put_acpi_device(adev); > err: > acpi_evaluate_ost(handle, type, ost_code, NULL); > }
-- With Best Regards, Andy Shevchenko
| |