Messages in this thread | | | Subject | Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs | From | Hans Verkuil <> | Date | Wed, 7 Jun 2017 11:01:06 +0200 |
| |
On 31/05/17 06:06, Joe Perches wrote: > On Wed, 2017-05-31 at 12:28 +0900, Hirokazu Honda wrote: >> If I understand a bitmap correctly, it is necessary to change the log level >> for each message. >> I didn't mean a bitmap will take a long CPU time. >> I mean the work to change so takes a long time. > > No, none of the messages or levels need change, > only the >= test changes to & so that for instance, > level 1 and level 3 messages could be emitted > without also emitting level 2 messages. > > The patch suggested is all that would be required. >
I prefer the solution that Joe proposed as well.
It's more useful, esp. with a complex beast like vb2.
Regards,
Hans
| |