lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V2 1/3] devicetree: add UniPhier WDT devicetree bindings documentation
Hayashibara-san


Just nitpicking.


2017-06-06 18:11 GMT+09:00 Keiji Hayashibara <hayashibara.keiji@socionext.com>:
> Add uniphier-wdt bindings documentation.
>
> Signed-off-by: Keiji Hayashibara <hayashibara.keiji@socionext.com>


Maybe "dt-bindings: watchdog: ..." for the subject.

This seems what Rob prefers.

For example,
https://patchwork.kernel.org/patch/9606365/



> ---
> .../devicetree/bindings/watchdog/uniphier-wdt.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> new file mode 100644
> index 0000000..a59d1ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> @@ -0,0 +1,20 @@
> +UniPhier watchdog timer controller
> +
> +This UniPhier watchdog timer controller must be under sysctrl compatible node.

Do you mean "syscon compatible" ?


> +Required properties:
> +- compatible: should be "socionext,uniphier-wdt"
> +
> +Example:
> +
> + sysctrl@61840000 {
> + compatible = "socionext,uniphier-ld11-sysctrl",
> + "simple-mfd", "syscon";
> + reg = <0x61840000 0x4000>;
> +
> + sys_wdt: watchdog {
> + compatible = "socionext,uniphier-wdt";
> + }

Could you remove the "sys_dwt: " label?
I'd like the example matched with actual DT files.


Thanks.


> + other nodes ...
> + };
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2017-06-12 01:20    [W:0.079 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site