lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 169/250] vxlan: correctly validate VXLAN ID against VXLAN_N_VID
    Date
    From: Matthias Schiffer <mschiffer@universe-factory.net>

    commit 4e37d6911f36545b286d15073f6f2222f840e81c upstream.

    The incorrect check caused an off-by-one error: the maximum VID 0xffffff
    was unusable.

    Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
    Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
    Acked-by: Jiri Benc <jbenc@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/net/vxlan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
    index a1dc186..8912ba8 100644
    --- a/drivers/net/vxlan.c
    +++ b/drivers/net/vxlan.c
    @@ -1386,7 +1386,7 @@ static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[])

    if (data[IFLA_VXLAN_ID]) {
    __u32 id = nla_get_u32(data[IFLA_VXLAN_ID]);
    - if (id >= VXLAN_VID_MASK)
    + if (id >= VXLAN_N_VID)
    return -ERANGE;
    }

    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:17    [W:4.070 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site