lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 176/250] isdn/gigaset: fix NULL-deref at probe
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 68c32f9c2a36d410aa242e661506e5b2c2764179 upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should a malicious device lack endpoints.

    Fixes: cf7776dc05b8 ("[PATCH] isdn4linux: Siemens Gigaset drivers - direct USB connection")
    Cc: Hansjoerg Lipp <hjlipp@web.de>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/isdn/gigaset/bas-gigaset.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
    index c44950d..6d4d9c1 100644
    --- a/drivers/isdn/gigaset/bas-gigaset.c
    +++ b/drivers/isdn/gigaset/bas-gigaset.c
    @@ -2317,6 +2317,9 @@ static int gigaset_probe(struct usb_interface *interface,
    return -ENODEV;
    }

    + if (hostif->desc.bNumEndpoints < 1)
    + return -ENODEV;
    +
    dev_info(&udev->dev,
    "%s: Device matched (Vendor: 0x%x, Product: 0x%x)\n",
    __func__, le16_to_cpu(udev->descriptor.idVendor),
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:17    [W:4.078 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site