lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 041/250] USB: serial: pl2303: fix NULL-deref at open
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 76ab439ed1b68778e9059c79ecc5d14de76c89a8 upstream.

    Fix NULL-pointer dereference in open() should a type-0 or type-1 device
    lack the expected endpoints:

    Unable to handle kernel NULL pointer dereference at virtual address 00000030
    ...
    PC is at pl2303_open+0x38/0xec [pl2303]

    Note that a missing interrupt-in endpoint would have caused open() to
    fail.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/usb/serial/pl2303.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
    index 33313ca..f496c38 100644
    --- a/drivers/usb/serial/pl2303.c
    +++ b/drivers/usb/serial/pl2303.c
    @@ -175,9 +175,17 @@ static int pl2303_vendor_write(__u16 value, __u16 index,
    static int pl2303_startup(struct usb_serial *serial)
    {
    struct pl2303_serial_private *spriv;
    + unsigned char num_ports = serial->num_ports;
    enum pl2303_type type = type_0;
    unsigned char *buf;

    + if (serial->num_bulk_in < num_ports ||
    + serial->num_bulk_out < num_ports ||
    + serial->num_interrupt_in < num_ports) {
    + dev_err(&serial->interface->dev, "missing endpoints\n");
    + return -ENODEV;
    + }
    +
    spriv = kzalloc(sizeof(*spriv), GFP_KERNEL);
    if (!spriv)
    return -ENOMEM;
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:14    [W:4.036 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site