lkml.org 
[lkml]   [2017]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/7] USB: of: fix root-hub device-tree node handling
    On Mon, Jun 05, 2017 at 12:51:04PM +0800, Peter Chen wrote:
    > On Tue, May 30, 2017 at 06:25:52PM +0200, Johan Hovold wrote:
    > > In an attempt to work around a pinmux over-allocation issue in driver
    > > core, commit dc5878abf49c ("usb: core: move root hub's device node
    > > assignment after it is added to bus") moved the device-tree node
    > > assignment until after the root hub had been registered.
    > >
    > > This not only makes the device-tree node unavailable to the usb driver
    > > during probe, but also prevents the of_node from being linked to in
    > > sysfs and causes a race with user-space for the (recently added) devspec
    > > attribute.
    > >
    > > Use the new device_set_of_node_from_dev() helper to reuse the node of
    > > the sysdev device, something which now prevents driver core from trying
    > > to reclaim any pinctrl pins during probe.
    > >
    > > Fixes: dc5878abf49c ("usb: core: move root hub's device node assignment after it is added to bus")
    > > Fixes: 51fa91475e43 ("usb/core: Added devspec sysfs entry for devices behind the usb hub")
    > > Signed-off-by: Johan Hovold <johan@kernel.org>

    > I am OK with it, but I suggest adding it for new rc1 since it is based
    > on the 1st patch which is a bug-fix. If this one is really needed for
    > stable tree in future, you can cherry-pick it.

    I agree, and didn't intent for this one to go into 4.12-rc. Let's see
    how Greg wants to handle this. I'll add some comments to the cover
    letter in v2.

    Thanks,
    Johan

    \
     
     \ /
      Last update: 2017-06-12 00:49    [W:6.634 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site