lkml.org 
[lkml]   [2017]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 11/27] thunderbolt: Do not fail if DROM data CRC32 is invalid
    Date
    There are devices out there where CRC32 of the DROM is not correct. One
    reason for this is that the ICM firmware does not validate it and it
    seems that neither does the Apple driver. To be able to support such
    devices we continue parsing the DROM contents regardless of whether
    CRC32 failed or not. We still keep the warning there.

    Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    Reviewed-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
    Reviewed-by: Michael Jamet <michael.jamet@intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
    ---
    drivers/thunderbolt/eeprom.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c
    index 7e485e3ef27e..e2c1f8a45522 100644
    --- a/drivers/thunderbolt/eeprom.c
    +++ b/drivers/thunderbolt/eeprom.c
    @@ -485,9 +485,8 @@ int tb_drom_read(struct tb_switch *sw)
    crc = tb_crc32(sw->drom + TB_DROM_DATA_START, header->data_len);
    if (crc != header->data_crc32) {
    tb_sw_warn(sw,
    - "drom data crc32 mismatch (expected: %#x, got: %#x), aborting\n",
    + "drom data crc32 mismatch (expected: %#x, got: %#x), continuing\n",
    header->data_crc32, crc);
    - goto err;
    }

    if (header->device_rom_revision > 2)
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-06-12 00:46    [W:3.937 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site