lkml.org 
[lkml]   [2017]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 4/4] net: macb: Add hardware PTP support
Date
> From: Richard Cochran [mailto:richardcochran@gmail.com]
> Sent: 4 czerwca 2017 22:55
> To: Rafal Ozieblo <rafalo@cadence.com>
> Cc: David Miller <davem@davemloft.net>; nicolas.ferre@atmel.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> harini.katakam@xilinx.com; andrei.pistirica@microchip.com
> Subject: Re: [PATCH v2 4/4] net: macb: Add hardware PTP support
>
> On Fri, Jun 02, 2017 at 03:28:10PM +0100, Rafal Ozieblo wrote:
>
> > +int gem_get_hwtst(struct net_device *dev, struct ifreq *rq)
> > +{
> > + struct macb *bp = netdev_priv(dev);
> > + struct hwtstamp_config *tstamp_config = &bp->tstamp_config;
> > +
> > + if ((bp->hw_dma_cap & HW_DMA_CAP_PTP) == 0)
> > + return -EFAULT;
>
> Segmentation fault? Really?
>
> ...
>
> > +int gem_set_hwtst(struct net_device *dev, struct ifreq *ifr, int cmd)
> > +{
> > + struct macb *bp = netdev_priv(dev);
> > + struct hwtstamp_config *tstamp_config = &bp->tstamp_config;
> > + enum macb_bd_control tx_bd_control = TSTAMP_DISABLED;
> > + enum macb_bd_control rx_bd_control = TSTAMP_DISABLED;
> > + u32 regval;
> > +
> > + if ((bp->hw_dma_cap & HW_DMA_CAP_PTP) == 0)
> > + return -EFAULT;
>
> here again
Would "ENOTSUP" be sufficient ?

>
> Thanks,
> Richard

Regards,
Rafal

\
 
 \ /
  Last update: 2017-06-12 00:42    [W:0.137 / U:1.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site