lkml.org 
[lkml]   [2017]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API
From
Date
On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote:
> > - if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> > -  CPER_SEC_PLATFORM_MEM)) {
> > + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM))
> > {
>
> The "!" here seems incorrect.
>
> >  #ifdef CONFIG_ACPI_APEI_PCIEAER
> > - else if (!uuid_le_cmp(*(uuid_le *)gdata-
> > >section_type,
> > -       CPER_SEC_PCIE)) {
> > + else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {
>
> Same here.

Thanks!
Are you going to fixup when applying or better me to send an updated
version?

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2017-06-12 00:30    [W:0.074 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site