lkml.org 
[lkml]   [2017]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.11 045/115] fs/ufs: Set UFS default maximum bytes per file
    Date
    4.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Richard Narron <comet.berkeley@gmail.com>

    commit 239e250e4acbc0104d514307029c0839e834a51a upstream.

    This fixes a problem with reading files larger than 2GB from a UFS-2
    file system:

    https://bugzilla.kernel.org/show_bug.cgi?id=195721

    The incorrect UFS s_maxsize limit became a problem as of commit
    c2a9737f45e2 ("vfs,mm: fix a dead loop in truncate_inode_pages_range()")
    which started using s_maxbytes to avoid a page index overflow in
    do_generic_file_read().

    That caused files to be truncated on UFS-2 file systems because the
    default maximum file size is 2GB (MAX_NON_LFS) and UFS didn't update it.

    Here I simply increase the default to a common value used by other file
    systems.

    Signed-off-by: Richard Narron <comet.berkeley@gmail.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Will B <will.brokenbourgh2877@gmail.com>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ufs/super.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    --- a/fs/ufs/super.c
    +++ b/fs/ufs/super.c
    @@ -812,9 +812,8 @@ static int ufs_fill_super(struct super_b
    uspi->s_dirblksize = UFS_SECTOR_SIZE;
    super_block_offset=UFS_SBLOCK;

    - /* Keep 2Gig file limit. Some UFS variants need to override
    - this but as I don't know which I'll let those in the know loosen
    - the rules */
    + sb->s_maxbytes = MAX_LFS_FILESIZE;
    +
    switch (sbi->s_mount_opt & UFS_MOUNT_UFSTYPE) {
    case UFS_MOUNT_UFSTYPE_44BSD:
    UFSD("ufstype=44bsd\n");

    \
     
     \ /
      Last update: 2017-06-12 00:26    [W:4.165 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site