lkml.org 
[lkml]   [2017]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 46/53] xfs: support ability to wait on new inodes
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Brian Foster <bfoster@redhat.com>

    commit 756baca27fff3ecaeab9dbc7a5ee35a1d7bc0c7f upstream.

    Inodes that are inserted into the perag tree but still under
    construction are flagged with the XFS_INEW bit. Most contexts either
    skip such inodes when they are encountered or have the ability to
    handle them.

    The runtime quotaoff sequence introduces a context that must wait
    for construction of such inodes to correctly ensure that all dquots
    in the fs are released. In anticipation of this, support the ability
    to wait on new inodes. Wake the appropriate bit when XFS_INEW is
    cleared.

    Signed-off-by: Brian Foster <bfoster@redhat.com>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/xfs/xfs_icache.c | 5 ++++-
    fs/xfs/xfs_inode.h | 4 +++-
    2 files changed, 7 insertions(+), 2 deletions(-)

    --- a/fs/xfs/xfs_icache.c
    +++ b/fs/xfs/xfs_icache.c
    @@ -210,14 +210,17 @@ xfs_iget_cache_hit(

    error = inode_init_always(mp->m_super, inode);
    if (error) {
    + bool wake;
    /*
    * Re-initializing the inode failed, and we are in deep
    * trouble. Try to re-add it to the reclaim list.
    */
    rcu_read_lock();
    spin_lock(&ip->i_flags_lock);
    -
    + wake = !!__xfs_iflags_test(ip, XFS_INEW);
    ip->i_flags &= ~(XFS_INEW | XFS_IRECLAIM);
    + if (wake)
    + wake_up_bit(&ip->i_flags, __XFS_INEW_BIT);
    ASSERT(ip->i_flags & XFS_IRECLAIMABLE);
    trace_xfs_iget_reclaim_fail(ip);
    goto out_error;
    --- a/fs/xfs/xfs_inode.h
    +++ b/fs/xfs/xfs_inode.h
    @@ -208,7 +208,8 @@ xfs_get_initial_prid(struct xfs_inode *d
    #define XFS_IRECLAIM (1 << 0) /* started reclaiming this inode */
    #define XFS_ISTALE (1 << 1) /* inode has been staled */
    #define XFS_IRECLAIMABLE (1 << 2) /* inode can be reclaimed */
    -#define XFS_INEW (1 << 3) /* inode has just been allocated */
    +#define __XFS_INEW_BIT 3 /* inode has just been allocated */
    +#define XFS_INEW (1 << __XFS_INEW_BIT)
    #define XFS_ITRUNCATED (1 << 5) /* truncated down so flush-on-close */
    #define XFS_IDIRTY_RELEASE (1 << 6) /* dirty release already seen */
    #define __XFS_IFLOCK_BIT 7 /* inode is being flushed right now */
    @@ -453,6 +454,7 @@ static inline void xfs_finish_inode_setu
    xfs_iflags_clear(ip, XFS_INEW);
    barrier();
    unlock_new_inode(VFS_I(ip));
    + wake_up_bit(&ip->i_flags, __XFS_INEW_BIT);
    }

    static inline void xfs_setup_existing_inode(struct xfs_inode *ip)

    \
     
     \ /
      Last update: 2017-06-12 00:24    [W:7.639 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site