lkml.org 
[lkml]   [2017]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API
> @@ -165,11 +165,11 @@ static int extlog_print(struct notifier_block *nb, unsigned long val,
> err_seq++;
> gdata = (struct acpi_hest_generic_data *)(tmp + 1);
> if (gdata->validation_bits & CPER_SEC_VALID_FRU_ID)
> - fru_id = (uuid_le *)gdata->fru_id;
> + fru_id = (guid_t *)gdata->fru_id;
> if (gdata->validation_bits & CPER_SEC_VALID_FRU_TEXT)
> fru_text = gdata->fru_text;
> - sec_type = (uuid_le *)gdata->section_type;
> - if (!uuid_le_cmp(*sec_type, CPER_SEC_PLATFORM_MEM)) {
> + sec_type = (guid_t *)gdata->section_type;

From a quick look over the tree it seems like both fru_id and
section_type should be declared as guid_t in
struct acpi_hest_generic_data.

> + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {

The "!" seems incorrect here.

\
 
 \ /
  Last update: 2017-06-12 00:24    [W:0.187 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site