lkml.org 
[lkml]   [2017]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] signal: Avoid undefined behaviour in kill_something_info
On Mon 05-06-17 20:53:27, zhongjiang wrote:
> diff --git a/kernel/signal.c b/kernel/signal.c
> index ca92bcf..63148f7 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1395,6 +1395,12 @@ static int kill_something_info(int sig, struct siginfo *info, pid_t pid)
>
> read_lock(&tasklist_lock);
> if (pid != -1) {
> + /*
> + * -INT_MIN is undefined, it need to exclude following case to
> + * avoid the UBSAN detection.
> + */
> + if (pid == INT_MIN)
> + return -ESRCH;

this will obviously keep the tasklist_lock held...

> ret = __kill_pgrp_info(sig, info,
> pid ? find_vpid(-pid) : task_pgrp(current));
> } else {
> --
> 1.7.12.4

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2017-06-12 00:21    [W:0.048 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site