lkml.org 
[lkml]   [2017]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] media: platform: s3c-camif: fix arguments position in function call
From
Date
On 06/02/2017 05:43 AM, Gustavo A. R. Silva wrote:
> Hi Sylwester,
>
> Here is another patch in case you decide that it is
> better to apply this one.

Thanks, I applied this patch. In future please put any comments only after
the scissors ("---") line, the comments can be then discarded automatically
and there will be no need for manually editing the patch before applying.

--
Regards,
Sylwester

> Fix the position of the arguments in function call.
>
> Addresses-Coverity-ID: 1248800
> Addresses-Coverity-ID: 1269141
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
^^^^^

> drivers/media/platform/s3c-camif/camif-capture.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c
> index 1b30be72..25c7a7d 100644
> --- a/drivers/media/platform/s3c-camif/camif-capture.c
> +++ b/drivers/media/platform/s3c-camif/camif-capture.c
> @@ -80,7 +80,7 @@ static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp)
> camif_hw_set_test_pattern(camif, camif->test_pattern);
> if (variant->has_img_effect)
> camif_hw_set_effect(camif, camif->colorfx,
> - camif->colorfx_cb, camif->colorfx_cr);
> + camif->colorfx_cr, camif->colorfx_cb);
> if (variant->ip_revision == S3C6410_CAMIF_IP_REV)
> camif_hw_set_input_path(vp);
> camif_cfg_video_path(vp);
> @@ -364,7 +364,7 @@ irqreturn_t s3c_camif_irq_handler(int irq, void *priv)
> camif_hw_set_test_pattern(camif, camif->test_pattern);
> if (camif->variant->has_img_effect)
> camif_hw_set_effect(camif, camif->colorfx,
> - camif->colorfx_cb, camif->colorfx_cr);
> + camif->colorfx_cr, camif->colorfx_cb);
> vp->state &= ~ST_VP_CONFIG;
> }
> unlock:

\
 
 \ /
  Last update: 2017-06-05 12:08    [W:0.052 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site