Messages in this thread | | | Subject | Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect | From | Xiao Guangrong <> | Date | Tue, 6 Jun 2017 10:56:55 +0800 |
| |
On 06/05/2017 03:36 PM, Jay Zhou wrote:
>> /* enable ucontrol for s390 */ >> struct kvm_s390_ucas_mapping { >> diff --git a/memory.c b/memory.c >> index 4c95aaf..b836675 100644 >> --- a/memory.c >> +++ b/memory.c >> @@ -809,6 +809,13 @@ static void address_space_update_ioeventfds(AddressSpace *as) >> flatview_unref(view); >> } >> >> +static write_protect_all_fn write_func; > > I think there should be a declaration in memory.h, > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 7fc3f48..31f3098 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -1152,6 +1152,9 @@ void memory_global_dirty_log_start(void); > */ > void memory_global_dirty_log_stop(void); > > +typedef void (*write_protect_all_fn)(bool write); > +void memory_register_write_protect_all(write_protect_all_fn func); > + > void mtree_info(fprintf_function mon_printf, void *f); >
Thanks for your suggestion, Jay!
This code just demonstrates how to enable this feature in QEMU, i will carefully consider it and merger your suggestion when the formal patch is posted out.
| |