Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS | Date | Fri, 30 Jun 2017 21:01:14 +1000 |
| |
Fathi Boudra <fathi.boudra@linaro.org> writes:
> On 29 June 2017 at 12:01, Michael Ellerman <mpe@ellerman.id.au> wrote: >> Fathi Boudra <fathi.boudra@linaro.org> writes: >> >>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >>> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. >> >> Can you explain how it fixes the values for cross-compilation? > > When pkg-config is invoked in a cross-build environment, it will > return your sysroot headers path instead of the hardcoded > -I/usr/include/libmount > > For example in my oe environment, when I invoke "pkg-config --cflags > mount", it returns: > -I/build/tmp-rpb-glibc/sysroots/hikey/usr/include/libmount
Right, presumably because OE is setting PKG_CONFIG_SYSROOT_DIR etc.
So for folks doing it by hand it doesn't really help with cross compiling, but I guess it doesn't hurt either.
cheers
| |