lkml.org 
[lkml]   [2017]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dmaengine: idma64: print error message on platform_get_irq failure
From
Date
Hello Gustavo,

On 06/30/2017 10:34 AM, Gustavo A. R. Silva wrote:
> Print error message on platform_get_irq failure before return.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/dma/idma64.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
> index 1953e57..08ade66 100644
> --- a/drivers/dma/idma64.c
> +++ b/drivers/dma/idma64.c
> @@ -637,8 +637,10 @@ static int idma64_platform_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> chip->irq = platform_get_irq(pdev, 0);
> - if (chip->irq < 0)
> + if (chip->irq < 0) {
> + dev_err(dev, "failed to get IRQ: %d\n", chip->irq);
> return chip->irq;
> + }
>
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> chip->regs = devm_ioremap_resource(dev, mem);
>

you do it wrong, please *immedately* stop sending this kind of patches
and revoke all the ones which you have sent so far, one revoke message
for each sent patch is expected.

1) there must be no error level message printed out, if the returned
by platform_get_irq() value is -EPROBE_DEFER, this notice makes
all your patches *invalid*,

2) if you wish it, add the error message directly into platform_get_irq(),
then *remove* any similar error messages from the individual drivers.

--
With best wishes,
Vladimir

\
 
 \ /
  Last update: 2017-06-30 10:10    [W:0.026 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site