lkml.org 
[lkml]   [2017]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 09/27] thunderbolt: Convert switch to a device
On Fri, Jun 02, 2017 at 05:05:06PM +0300, Mika Westerberg wrote:
> Thunderbolt domain consists of switches that are connected to each
> other, forming a bus. This will convert each switch into a real Linux
> device structure and adds them to the domain. The advantage here is
> that we get all the goodies from the driver core, like reference
> counting and sysfs hierarchy for free.
>
> Also expose device identification information to the userspace via new
> sysfs attributes.
>
> In order to support internal connection manager (ICM) we separate switch
> configuration into its own function (tb_switch_configure()) which is
> only called by the existing native connection manager implementation
> used on Macs.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reviewed-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
> Reviewed-by: Michael Jamet <michael.jamet@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Documentation/ABI/testing/sysfs-bus-thunderbolt | 22 ++
> drivers/thunderbolt/eeprom.c | 2 +
> drivers/thunderbolt/switch.c | 261 +++++++++++++++++++-----
> drivers/thunderbolt/tb.c | 40 +++-
> drivers/thunderbolt/tb.h | 45 +++-
> 5 files changed, 303 insertions(+), 67 deletions(-)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-thunderbolt

For the driver model type changes, looks good to me, nice job:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

\
 
 \ /
  Last update: 2017-06-05 00:17    [W:0.219 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site