lkml.org 
[lkml]   [2017]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-sunxi] Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
在 2017-06-30 00:23,David Miller 写道:
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Tue, 27 Jun 2017 11:28:01 +0200
>
>> The current way to find if the phy is internal is to compare DT
>> phy-mode
>> and emac_variant/internal_phy.
>> But it will negate a possible future SoC where an external PHY use the
>> same phy mode than the internal one.
>>
>> By using phy-mode = "internal" we permit to have an external PHY with
>> the same mode than the internal one.
>>
>> Reported-by: André Przywara <andre.przywara@arm.com>
>> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Series applied.

I think there's still some problems around for this patchset...
The definition of "internal" is internal *proprietary* PHY, but the
internal PHY of Allwinner SoCs seem to be MII...

See [1].

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-June/516159.html

>
> Please provide a proper "[PATCH 0/n] " header posting next time.

\
 
 \ /
  Last update: 2017-06-29 18:47    [W:0.372 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site