lkml.org 
[lkml]   [2017]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled
    From
    Date
    On Thu, 2017-06-15 at 19:52 +0200, Greg Kroah-Hartman wrote:
    > 4.4-stable review patch. If anyone has any objections, please let me know.
    >
    > ------------------
    >
    > From: hayeswang <hayeswang@realtek.com>
    >
    >
    > [ Upstream commit de9bf29dd6e4a8a874cb92f8901aed50a9d0b1d3 ]
    >
    > Stop the tx when the napi is disabled to prevent napi_schedule() is
    > called.
    [...]
    > + netif_stop_queue(netdev);
    > napi_disable(&tp->napi);
    [...]

    netif_stop_queue() is not synchronous, so you probably need
    netif_tx_disable() instead.

    Ben.

    --
    Ben Hutchings
    Software Developer, Codethink Ltd.


    \
     
     \ /
      Last update: 2017-06-29 16:37    [W:3.509 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site