lkml.org 
[lkml]   [2017]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpiolib: fix filtering out unwanted events
On Thu, Jun 29, 2017 at 1:03 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> 2017-06-29 11:33 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
>> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>
>>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
>>> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>>>
>>> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
>>> evaluated to true even if only one event type was requested.
>>>
>>> Fix it by checking both RISING & FALLING flags explicitly.
>>>
>>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
>>
>> Patch applied for fixes.
>>
>> Yours,
>> Linus Walleij
>
> Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is
> affected). Will you forward it or should I do it myself?

I have added the stable tag so it should JustWork(TM).

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2017-06-29 15:16    [W:0.069 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site