lkml.org 
[lkml]   [2017]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] trace-listen: add missing header
On Thu, 29 Jun 2017 15:29:39 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> Hi Steven,
>
> On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote:
> > On Thu, 29 Jun 2017 14:46:21 +0300
> > Baruch Siach <baruch@tkos.co.il> wrote:
> >
> > > The PATH_MAX macro requires the limits.h header. This fixes build with musl
> > > libc:
> > >
> > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
> > > snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
> > > ^~~~~~~~
> >
> > Thanks! I have a few other patches that need to go into trace-cmd. I'll
> > try to get to that today or tomorrow.
>
> There is no rush.
>
> By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the
> same file might bite at some point. Also, MAX_PATH has different values in
> different files.

Yeah, that code should be cleaned up. It was probably me rushing to get
some feature in and not spending the time to do it nicely.

Feel free to send more patches ;-)

-- Steve

\
 
 \ /
  Last update: 2017-06-29 14:57    [W:0.055 / U:19.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site